Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.secretstorage: drop old dependency #85571

Merged
merged 1 commit into from Apr 19, 2020
Merged

pythonPackages.secretstorage: drop old dependency #85571

merged 1 commit into from Apr 19, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Apr 19, 2020

Motivation for this change

pygobject was an optional dependency at some point but it has been removed and is no longer needed. See #80740 (comment).

Things done
  • Tested using sandboxing ([nix.useSandbox
    (http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (saves ~500MB!)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from teto April 19, 2020 17:10
@rnhmjoj
pythonPackages.secretstorage: drop old dependency
c9a77e4 
pygobject was an optional dependency at some point but it has been
removed and is no longer needed.
@worldofpeace worldofpeace merged commit 2a8f5b0 into NixOS:master Apr 19, 2020
@rnhmjoj rnhmjoj mentioned this pull request Apr 21, 2020
Merged
10 tasks
@rnhmjoj rnhmjoj deleted the secretstorage branch June 19, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @worldofpeace