Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No extra copies of entities in Revolve and Helix groups. #581

Merged
merged 1 commit into from
Apr 21, 2020
Merged

No extra copies of entities in Revolve and Helix groups. #581

merged 1 commit into from
Apr 21, 2020

Conversation

phkahler
Copy link
Member

fixes issue #549.
Might break some older files with those groups.

@phkahler
Don't create extra copies of entities in Revolve and Helix groups. Fi…
27d937e 
…xes issue solvespace#549. Might break some older files with those groups.
@phkahler phkahler mentioned this pull request Apr 20, 2020
Closed
@phkahler
Copy link
Member Author

@whitequark any idea what's failing here?

@whitequark
Copy link
Contributor

any idea what's failing here?

Fluke? The cut off build log is indicative of that. Travis sometimes has issues like that on macOS, unfortunately.

@whitequark whitequark merged commit b55dac7 into solvespace:master Apr 21, 2020
@whitequark
Copy link
Contributor

Thanks for the fix!

@phkahler phkahler mentioned this pull request Apr 21, 2020
Merged
@phkahler phkahler deleted the issue549 branch April 21, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phkahler @whitequark