Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex-media-player: 2.40.0.1007 -> 2.55.0.1069 + update script #68938

Merged
merged 17 commits into from Apr 20, 2020
Merged

plex-media-player: 2.40.0.1007 -> 2.55.0.1069 + update script #68938

merged 17 commits into from Apr 20, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Sep 16, 2019

Motivation for this change

In the hope that the update process for the plex-media-player stays the same as in the last iterations, the update script should make the fix one hash per build process much faster.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kylewlacy

@B4dM4n B4dM4n changed the title plex-media-player: 2.40.0.1007 -> 2.41.0.1010 + update script plex-media-player: 2.40.0.1007 -> 2.42.0.1013 + update script Sep 29, 2019
kylewlacy
kylewlacy approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested this out with nix-build -A plex-media-player and it builds and runs great

(Also, this is my first time seeing an updateScript in a package, so for my own reference, this can be run with nix-shell maintainers/scripts/update.nix --argstr package plex-media-player within the nixpkgs repo)

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Oct 1, 2019

@kylewlacy 2.43.0.1015 is already out. Should I push the new version before this gets merged?

@kylewlacy
Copy link
Contributor

Sure, I'd say go for another version bump

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Oct 2, 2019

Latest version is pushed.

@B4dM4n B4dM4n changed the title plex-media-player: 2.40.0.1007 -> 2.42.0.1013 + update script plex-media-player: 2.40.0.1007 -> 2.43.0.1015 + update script Oct 2, 2019
kylewlacy
kylewlacy approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version also looks good!

@solson
Copy link
Member

solson commented Nov 14, 2019

Is this PR blocked on anything? I can't seem to build the current nixos-unstable version of this package.

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Nov 14, 2019

The build is currently blocked by #72384.

I'm currently experimenting with building this package with Qt 5.12 to get a working build.
It's not officially supported (see plexinc/plex-media-player#802), but working fine so far.
There are also less graphical glitches when running under wayland.

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Nov 14, 2019

@kylewlacy I pushed the latest upstream version which got released today. It sadly currently doesn't build on master due to the mentioned issue.

If anyone wants to try a Qt 5.12 build, I pushed a branch here:
B4dM4n:plex-media-player-qt512

nix run -f https://github.com/B4dM4n/nixpkgs/archive/plex-media-player-qt512.tar.gz plex-media-player -c plexmediaplayer

@B4dM4n B4dM4n changed the title plex-media-player: 2.40.0.1007 -> 2.43.0.1015 + update script plex-media-player: 2.40.0.1007 -> 2.45.0.1028 + update script Nov 14, 2019
@kylewlacy
Copy link
Contributor

I don't have the ability to merge this PR

@B4dM4n B4dM4n changed the title plex-media-player: 2.40.0.1007 -> 2.45.0.1028 + update script plex-media-player: 2.40.0.1007 -> 2.47.0.1035 + update script Dec 17, 2019
@colemickens
Copy link
Member

This LGTM, thanks for doing it!

@B4dM4n B4dM4n changed the title plex-media-player: 2.40.0.1007 -> 2.47.0.1035 + update script plex-media-player: 2.40.0.1007 -> 2.48.0.1038 + update script Jan 8, 2020
@B4dM4n
Copy link
Contributor Author

B4dM4n commented Jan 8, 2020

The next version is out.

I needed to rebase onto master because update-source-versions wasn't working on the old branch anymore.

@johnpyp
Copy link
Contributor

johnpyp commented Jan 17, 2020

Any news on when this can be merged?

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Feb 13, 2020

The PR ist ready to be merged at any time. I'm using the version in this branch via an overlay and there have been no issues so far.

Using the update script to keep track of the upstream releases is painless now and works really well.

Any idea who to ping to get this merged?

@kylewlacy
Copy link
Contributor

Okay, so I was added to the NixOS GitHub org, but for some reason I'm still not able to merge this PR... I'm still completely in the dark on how to get this merged in

@B4dM4n B4dM4n changed the title plex-media-player: 2.40.0.1007 -> 2.48.0.1038 + update script plex-media-player: 2.40.0.1007 -> 2.52.2.1056 + update script Mar 12, 2020
@ofborg ofborg bot requested a review from kylewlacy March 12, 2020 19:55
kylewlacy
kylewlacy approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mic92
Copy link
Member

Mic92 commented Apr 20, 2020

I will have a look at it.

@Mic92 Mic92 changed the title plex-media-player: 2.40.0.1007 -> 2.52.2.1056 + update script plex-media-player: 2.40.0.1007 -> 2.55.0.1069 + update script Apr 20, 2020
@Mic92 Mic92 merged commit 41582c7 into NixOS:master Apr 20, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 20, 2020

Thanks for keeping this up to date.

@B4dM4n B4dM4n deleted the plex-media-player-update branch April 22, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylewlacy kylewlacy kylewlacy approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@B4dM4n @kylewlacy @solson @colemickens @johnpyp @Mic92