Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citrix_workspace: add 2004 #85608

Merged
merged 1 commit into from Apr 21, 2020
Merged

citrix_workspace: add 2004 #85608

merged 1 commit into from Apr 21, 2020

Conversation

obadz
Copy link
Contributor

@obadz obadz commented Apr 20, 2020

Motivation for this change

Update to 20.04.
Note: large displays previously triggered the creation of virtual monitors within the Citrix session (which prevented maximizing windows across entire display). This now seems to be fixed!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Ma27 April 20, 2020 14:14
@Ma27
Copy link
Member

Ma27 commented Apr 21, 2020

Thanks! I've already seen it, I'll hopefully be able to test it today :)

@Ma27 Ma27 merged commit edeaab2 into NixOS:master Apr 21, 2020
@obadz obadz deleted the citrix-2004 branch April 21, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@obadz @Ma27