Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus: 2.17.1 -> 2.17.2 #85615

Merged
merged 1 commit into from Apr 25, 2020
Merged

prometheus: 2.17.1 -> 2.17.2 #85615

merged 1 commit into from Apr 25, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Apr 20, 2020 •
edited

Motivation for this change

https://github.com/prometheus/prometheus/releases/tag/v2.17.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested review from benley, fpletz, globin and WilliButz April 20, 2020 15:12
@Frostman
Copy link
Member Author

@marsam yep, thx, I've missed committing part with the sha.

@Frostman
Copy link
Member Author

@GrahamcOfBorg test prometheus

1 similar comment
@globin
Copy link
Member

globin commented Apr 23, 2020

@GrahamcOfBorg test prometheus

@marsam marsam merged commit 2083e47 into NixOS:master Apr 25, 2020
@Frostman Frostman deleted the prom-2.17.2 branch April 25, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@benley benley Awaiting requested review from benley

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @globin @marsam