Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alot: Use bundled theme files #85607

Merged
merged 1 commit into from Aug 5, 2020
Merged

alot: Use bundled theme files #85607

merged 1 commit into from Aug 5, 2020

Conversation

kirelagin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from oxzi April 20, 2020 14:11
@kirelagin
Copy link
Member Author

Ping @geistesk, @FRidh, @jonringer.

@kirelagin
Copy link
Member Author

Rebased onto master. Also, I guess, now ping @edibopp.

@ofborg ofborg bot requested a review from milibopp July 19, 2020 07:14
oxzi
oxzi approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR successfully.

Without the XDG_DATA_DIRS environmental variable, alot now checks at the correct location within the nix store for theme files.

Sorry for this delay, btw. It would also be nice for further PRs to briefly explain the effects of the proposed changes.

milibopp
milibopp approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@milibopp milibopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, I should have checked for open issues, when I took over maintenance ;)

Thanks for the review @geistesk, looks good to me. But I'm not allowed to merge.

jonringer
jonringer approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/85607
2 packages built:
alot python37Packages.alot

@jonringer jonringer merged commit be04d53 into NixOS:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milibopp milibopp milibopp approved these changes

@jonringer jonringer jonringer approved these changes

@oxzi oxzi oxzi approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kirelagin @milibopp @jonringer @oxzi