treewide: add bool type to enable options, or make use of mkEnableOption #85628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: GNOME
xaverdh
force-pushed
the
enable-add-type
branch
from
c0e99be
to
ac64121
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
Side note: It would have been useful (for testing this) if the |
xaverdh
force-pushed
the
enable-add-type
branch
from
ac64121
to
f5ec008
Compare
Add missing type information to manually specified enable options or replace them by mkEnableOption where appropriate.
xaverdh
force-pushed
the
enable-add-type
branch
from
f5ec008
to
0412bde
Compare
|
The |
|
Thanks! |
|
Might be worth a backport. |
|
For reference: #76184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When trying out the nixos-manager graphical user interface for nixos, I noticed that lots of services had enable options without type information, leading to nixos-manager not showing a slider for them.
Fix this by adding missing type information to manually specified enable options or replacing them by mkEnableOption where appropriate (i.e. trivial text with service name and such).