Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nixos/tools: adapt for renamed console options #85644

Merged
merged 1 commit into from Apr 21, 2020
Merged

[20.03] nixos/tools: adapt for renamed console options #85644

merged 1 commit into from Apr 21, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2020

Motivation for this change

Backport of #85643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost changed the title nixos/tools: adapt for renamed console options [20.03] nixos/tools: adapt for renamed console options Apr 21, 2020
@ghost ghost requested a review from basvandijk April 21, 2020 13:34
@worldofpeace worldofpeace merged commit 4a549b8 into NixOS:release-20.03 Apr 21, 2020
@worldofpeace
Copy link
Contributor

Thanks, I could of swore this happened, but I guess it didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace