Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-live-desktop: 2.1.0 -> 2.3.2 #85646

Merged
merged 2 commits into from May 12, 2020
Merged

ledger-live-desktop: 2.1.0 -> 2.3.2 #85646

merged 2 commits into from May 12, 2020

Conversation

nyanloutre
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pnelson pnelson self-requested a review April 29, 2020 02:21
pnelson
pnelson approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@pnelson pnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine.

felschr
felschr reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@felschr felschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2.3.2 has been released.

pkgs/applications/blockchains/ledger-live-desktop/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/ledger-live-desktop/default.nix Outdated Show resolved Hide resolved
@nyanloutre @felschr
ledger-live-desktop: 2.2.4 -> 2.3.2
11a9fbe 
Co-authored-by: Felix Tenley <felschr@gmail.com>
@nyanloutre nyanloutre changed the title ledger-live-desktop: 2.1.0 -> 2.2.4 ledger-live-desktop: 2.1.0 -> 2.3.2 Apr 30, 2020
@felschr
Copy link
Member

felschr commented May 9, 2020 •
edited

Builds and runs fine for me.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/152

@bhipple
Copy link
Contributor

bhipple commented May 12, 2020

Result of nixpkgs-review pr 85646 1

1 package built:
- ledger-live-desktop

@bhipple bhipple merged commit 49540ba into NixOS:master May 12, 2020
@nyanloutre nyanloutre deleted the ledger_live_2_2_4 branch September 9, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felschr felschr felschr left review comments

@pnelson pnelson pnelson approved these changes

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nyanloutre @felschr @nixos-discourse @bhipple @pnelson