[20.03] pythonPackages.stem: unbroken at 1.8.0 #85642
Conversation
The update has already been made on master. The bug is just with the test suite on python 3.8 so we could just skip the tests if preferred. See bug report: <https://trac.torproject.org/projects/tor/ticket/30847>.
|
@GrahamcOfBorg build pythonPackages.stem python3Packages.stem |
|
See suggestion at #85896 (review) for how to make test suite pass with py38 |
|
@drewrisinger The test suite is passing. Patching is unnecessary because the bug was fixed in 1.8.0. |
Ok, that's not what I understood from the header. |
|
@drewrisinger Ah, I now see the ambiguity and edited the header to clarify it. |
There was a problem hiding this comment.
When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.
Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build
A third attempt after NixOS#85642 which I hadn't recognized as a backport of NixOS#81679. The bug is just with the test suite on python 3.8 which was fixed in 1.8.0. See bug report: https://trac.torproject.org/projects/tor/ticket/30847. (cherry picked from commit 618cdd2)
|
I hadn't recognized this as a backport because I wasn't sure if upgrading would be the accepted solution (over patching or test-skipping). There don't seem to be any objections so I'll assume upgrading is fine. Closing in favor of #86008. |
|
You don't have to keep closing your pull requests every time you want to change them. You can still push to the branch that this PR was based on. If you want to re-do your commits, you can e.g. amend them and then force-push |
A third attempt after NixOS#85642 which I hadn't recognized as a backport of NixOS#81679. The bug is just with the test suite on python 3.8 which was fixed in 1.8.0. See bug report: https://trac.torproject.org/projects/tor/ticket/30847. (cherry picked from commit 618cdd2)
Motivation for this change
A second attempt after #85632.
The update has already been made on master.
The bug is just with the test suite on python 3.8 which was fixed in 1.8.0, so if we'd prefer not to update to 1.8.0 we could skip the tests or backport the patch instead. See bug report:
https://trac.torproject.org/projects/tor/ticket/30847.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)