Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TLP charge thresholds #154

Merged
merged 1 commit into from Apr 21, 2020
Merged

Change TLP charge thresholds #154

merged 1 commit into from Apr 21, 2020

Conversation

j0hax
Copy link
Member

@j0hax j0hax commented Apr 21, 2020

Set TLP charging thresholds to values recommended by the TLP developer on ThinkPad-Forum.de.

@j0hax j0hax requested a review from lukateras as a code owner April 21, 2020 01:01
@Mic92
Copy link
Member

Mic92 commented Apr 21, 2020

The thread does not quite look like TLP developer but rather users. Actually in the wiki article it says that one has to recalibrate the battery to reach the full capacity again. So I am not quite sure how they came up with the thresholds here.

@j0hax
Copy link
Member Author

j0hax commented Apr 21, 2020

The ArchWiki claims there is a hardware bug and also references the thread. Maybe the original developer, @linrunner, has further information?

@Mic92 Mic92 merged commit 1633661 into NixOS:master Apr 21, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 21, 2020

It survived the archlinux wiki. Let's keep it.

@linrunner
Copy link

I would advise against activating charge thresholds ootb in a Linux installation. Better to point users to the TLP FAQ so they can make their choice: https://linrunner.de/en/tlp/docs/tlp-faq.html#battery

67/100 are my personal settings for the X220 because of this: https://linrunner.de/en/tlp/docs/tlp-faq.html#erratic-battery

@Mic92
Copy link
Member

Mic92 commented Apr 21, 2020

@linrunner so you would not recommend this setting on x230 by default? Note that this configuration is applied to x230 only.

@linrunner
Copy link

As i said above. TLP enables users to use charge thresholds but won't enforce them. You have to consider that they come at the cost of a more or less reduced battery runtime.

Mic92 added a commit to Mic92/nixos-hardware that referenced this pull request Apr 21, 2020
This reverts commit 76f6813.

This setting is opinionated and should be left to the user.
See: NixOS#154 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants