Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5e76bf706bfa
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 203955fa0c65
Choose a head ref
  • 2 commits
  • 8 files changed
  • 2 contributors

Commits on Apr 20, 2020

  1. libtxc_dxtn{,_s2tc}: remove from nixpkgs + hardware.opengl options

    Context: discussion in #82630
    
    Mesa has been supporting S3TC natively without requiring these libraries
    since the S3TC patent expired in December 2017.
    delroth committed Apr 20, 2020

    Verified

    This commit was signed with the committer’s verified signature.
    delroth Pierre Bourdon
    Copy the full SHA
    1b89bff View commit details
  2. Merge pull request #82714 from delroth/s3tc

    libtxc_dxtn{,_s2tc}: remove from nixpkgs + hardware.opengl options
    Ekleog authored Apr 20, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    203955f View commit details
26 changes: 5 additions & 21 deletions nixos/modules/hardware/opengl.nix
Original file line number Diff line number Diff line change
@@ -10,14 +10,6 @@ let

videoDrivers = config.services.xserver.videoDrivers;

makePackage = p: pkgs.buildEnv {
name = "mesa-drivers+txc-${p.mesa.version}";
paths =
[ p.mesa.drivers
(if cfg.s3tcSupport then p.libtxc_dxtn else p.libtxc_dxtn_s2tc)
];
};

package = pkgs.buildEnv {
name = "opengl-drivers";
paths = [ cfg.package ] ++ cfg.extraPackages;
@@ -34,6 +26,9 @@ in

imports = [
(mkRenamedOptionModule [ "services" "xserver" "vaapiDrivers" ] [ "hardware" "opengl" "extraPackages" ])
(mkRemovedOptionModule [ "hardware" "opengl" "s3tcSupport" ] ''
S3TC support is now always enabled in Mesa.
'')
];

options = {
@@ -74,17 +69,6 @@ in
'';
};

s3tcSupport = mkOption {
type = types.bool;
default = false;
description = ''
Make S3TC(S3 Texture Compression) via libtxc_dxtn available
to OpenGL drivers instead of the patent-free S2TC replacement.
Using this library may require a patent license depending on your location.
'';
};

package = mkOption {
type = types.package;
internal = true;
@@ -166,8 +150,8 @@ in
environment.sessionVariables.LD_LIBRARY_PATH = mkIf cfg.setLdLibraryPath
([ "/run/opengl-driver/lib" ] ++ optional cfg.driSupport32Bit "/run/opengl-driver-32/lib");

hardware.opengl.package = mkDefault (makePackage pkgs);
hardware.opengl.package32 = mkDefault (makePackage pkgs.pkgsi686Linux);
hardware.opengl.package = mkDefault pkgs.mesa.drivers;
hardware.opengl.package32 = mkDefault pkgs.pkgsi686Linux.mesa.drivers;

boot.extraModulePackages = optional (elem "virtualbox" videoDrivers) kernelPackages.virtualboxGuestAdditions;
};
2 changes: 1 addition & 1 deletion pkgs/applications/misc/lutris/chrootenv.nix
Original file line number Diff line number Diff line change
@@ -94,7 +94,7 @@ in buildFHSUserEnv {
libsndfile libtheora libogg libvorbis libopus libGLU libpcap libpulseaudio
libao libusb libevdev udev libgcrypt libxml2 libusb libpng libmpeg2 libv4l
libjpeg libxkbcommon libass libcdio libjack2 libsamplerate libzip libmad libaio
libcap libtiff libva libgphoto2 libxslt libtxc_dxtn libsndfile giflib zlib glib
libcap libtiff libva libgphoto2 libxslt libsndfile giflib zlib glib
alsaLib zziplib bash dbus keyutils zip cabextract freetype unzip coreutils
readline gcc SDL SDL2 curl graphite2 gtk2 gtk3 udev ncurses wayland libglvnd
vulkan-loader xdg_utils sqlite gnutls libbsd
23 changes: 0 additions & 23 deletions pkgs/development/libraries/libtxc_dxtn/default.nix

This file was deleted.

25 changes: 0 additions & 25 deletions pkgs/development/libraries/libtxc_dxtn_s2tc/default.nix

This file was deleted.

2 changes: 0 additions & 2 deletions pkgs/misc/emulators/wine/default.nix
Original file line number Diff line number Diff line change
@@ -9,7 +9,6 @@
{ lib, stdenv, callPackage,
wineRelease ? "stable",
wineBuild ? if stdenv.hostPlatform.system == "x86_64-linux" then "wineWow" else "wine32",
libtxc_dxtn_Name ? "libtxc_dxtn_s2tc",
pngSupport ? false,
jpegSupport ? false,
tiffSupport ? false,
@@ -63,7 +62,6 @@ let wine-build = build: release:

in if wineRelease == "staging" then
callPackage ./staging.nix {
inherit libtxc_dxtn_Name;
wineUnstable = wine-build wineBuild "unstable";
}
else
4 changes: 2 additions & 2 deletions pkgs/misc/emulators/wine/staging.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, callPackage, wineUnstable, libtxc_dxtn_Name }:
{ stdenv, callPackage, wineUnstable }:

with callPackage ./util.nix {};

@@ -8,7 +8,7 @@ let patch = (callPackage ./sources.nix {}).staging;
in assert stdenv.lib.getVersion wineUnstable == patch.version;

stdenv.lib.overrideDerivation wineUnstable (self: {
buildInputs = build-inputs [ "perl" "utillinux" "autoconf" libtxc_dxtn_Name ] self.buildInputs;
buildInputs = build-inputs [ "perl" "utillinux" "autoconf" ] self.buildInputs;

name = "${self.name}-staging";

2 changes: 2 additions & 0 deletions pkgs/top-level/aliases.nix
Original file line number Diff line number Diff line change
@@ -245,6 +245,8 @@ mapAliases ({
librecad2 = librecad; # backwards compatibility alias, added 2015-10
libsysfs = sysfsutils; # added 2018-04-25
libtidy = html-tidy; # added 2014-12-21
libtxc_dxtn = throw "removed 2020-03-16, now integrated in Mesa";
libtxc_dxtn_s2tc = throw "removed 2020-03-16, now integrated in Mesa";
libudev = udev; # added 2018-04-25
libsexy = throw "libsexy has been removed from nixpkgs, as it's abandoned and no package needed it."; # 2019-12-10
links = links2; # added 2016-01-31
4 changes: 0 additions & 4 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
@@ -13278,10 +13278,6 @@ in

libtsm = callPackage ../development/libraries/libtsm { };

libtxc_dxtn = callPackage ../development/libraries/libtxc_dxtn { };

libtxc_dxtn_s2tc = callPackage ../development/libraries/libtxc_dxtn_s2tc { };

libgeotiff = callPackage ../development/libraries/libgeotiff { };

libu2f-host = callPackage ../development/libraries/libu2f-host { };