Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A point to start #15

Merged
merged 5 commits into from Apr 21, 2020
Merged

A point to start #15

merged 5 commits into from Apr 21, 2020

Conversation

auge8472
Copy link
Contributor

This is a collection of further base changes and corrections in preparation for the work on styling.

  • move the <header> tags from the individual templates to base.html (sorry for the previous, inappropriate solution)
  • add <nav> and <main> to base.html
  • set an ID (system-notices) for the list template for system messages in base.html
  • replace <h3> with <p> in the new pages (tos versions 1.0, 1.1 and 1.3)
  • create page.css with the first, rudimentary rules and link the CSS-file in base.css

With these changes, we can address all elements with specific and different approaches for the different main sections of the pages (<nav>, <header>, <main> sections).

@frosch123 frosch123 merged commit 5189d9d into OpenTTD:master Apr 21, 2020
@frosch123
Copy link
Member

FYI:
The master branch is now auto-deployed to
https://bananas.staging.openttd.org/

@auge8472
Copy link
Contributor Author

The master branch is now auto-deployed

Thank you.

Do you know, why the last automatic code test did not finish for more or less a complete day?

@auge8472 auge8472 deleted the html-main branch April 21, 2020 21:21
@frosch123
Copy link
Member

No idea. It's some external thing.
But it checks python, so I ignored it for template changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants