New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minigalaxy: init at 0.9.4 #85658
minigalaxy: init at 0.9.4 #85658
Conversation
|
||
buildInputs = [ glib-networking gobject-introspection gtk3 setuptools ]; | ||
nativeBuildInputs = [ gettext wrapGAppsHook ]; | ||
propagatedBuildInputs = [ docutils pygobject3 requests steam-run webkitgtk ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
propagatedBuildInputs
adds all subdependencies to binary path, which is not needed, so replace withpythonPath
- add more required and optional depencies
propagatedBuildInputs = [ docutils pygobject3 requests steam-run webkitgtk ]; | |
pythonPath = [ docutils pygobject3 requests steam-run webkitgtk | |
unzip xdg_utils scummvm dosbox wine | |
]; |
|
||
postFixup = '' | ||
# Run Linux games using the Steam Runtime by using steam-run in the wrapper | ||
sed -e 's/exec -a "$0"/exec -a "$0" steam-run/' -i $out/bin/minigalaxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix breaks initial gog web authorization, so perhaps replace it with steam-run-native
? User will be able to override it like minigalaxy.override { steam-run-native = steam-run }
after authorization if needed.
sed -e 's/exec -a "$0"/exec -a "$0" steam-run/' -i $out/bin/minigalaxy | |
sed -e 's#exec -a "$0"#exec -a "$0" ${steam-run-native}/bin/steam-run#' -i $out/bin/minigalaxy |
sha256 = "0m8r5gb1k9cjji64rswximl49klychxzbzxhmfrpjq57c0zg5vs8"; | ||
}; | ||
|
||
# Don't test to avoid error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify this. Are the tests broken?
buildInputs = [ glib-networking gobject-introspection gtk3 setuptools ]; | ||
nativeBuildInputs = [ gettext wrapGAppsHook ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildInputs = [ glib-networking gobject-introspection gtk3 setuptools ]; | |
nativeBuildInputs = [ gettext wrapGAppsHook ]; | |
nativeBuildInputs = [ gettext wrapGAppsHook ]; | |
buildInputs = [ glib-networking gobject-introspection gtk3 setuptools ]; |
maintainers = with maintainers; [ joshuafern ]; | ||
platforms = platforms.linux; | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing final newline.
Result of 1 package built:
|
I marked this as stale due to inactivity. → More info |
Closing this stale PR. |
Motivation for this change
Minigalaxy is a simple GOG client.
I've used
steam-run
in the wrapper to run Linux games with the Steam Runtime. It feels a little hacky to do it this way but it ends up working great. Why create yet another FHSUserEnv when we already have an existing one designed to run games?Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)