Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minigalaxy: init at 0.9.4 #85658

Closed
wants to merge 2 commits into from
Closed

minigalaxy: init at 0.9.4 #85658

wants to merge 2 commits into from

Conversation

JoshuaFern
Copy link
Member

Motivation for this change

Minigalaxy is a simple GOG client.

I've used steam-run in the wrapper to run Linux games with the Steam Runtime. It feels a little hacky to do it this way but it ends up working great. Why create yet another FHSUserEnv when we already have an existing one designed to run games?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.


buildInputs = [ glib-networking gobject-introspection gtk3 setuptools ];
nativeBuildInputs = [ gettext wrapGAppsHook ];
propagatedBuildInputs = [ docutils pygobject3 requests steam-run webkitgtk ];
Copy link

@ghost ghost Jul 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • propagatedBuildInputs adds all subdependencies to binary path, which is not needed, so replace with pythonPath
  • add more required and optional depencies
Suggested change
propagatedBuildInputs = [ docutils pygobject3 requests steam-run webkitgtk ];
pythonPath = [ docutils pygobject3 requests steam-run webkitgtk
unzip xdg_utils scummvm dosbox wine
];


postFixup = ''
# Run Linux games using the Steam Runtime by using steam-run in the wrapper
sed -e 's/exec -a "$0"/exec -a "$0" steam-run/' -i $out/bin/minigalaxy
Copy link

@ghost ghost Jul 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix breaks initial gog web authorization, so perhaps replace it with steam-run-native? User will be able to override it like minigalaxy.override { steam-run-native = steam-run } after authorization if needed.

Suggested change
sed -e 's/exec -a "$0"/exec -a "$0" steam-run/' -i $out/bin/minigalaxy
sed -e 's#exec -a "$0"#exec -a "$0" ${steam-run-native}/bin/steam-run#' -i $out/bin/minigalaxy

sha256 = "0m8r5gb1k9cjji64rswximl49klychxzbzxhmfrpjq57c0zg5vs8";
};

# Don't test to avoid error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify this. Are the tests broken?

Comment on lines +19 to +20
buildInputs = [ glib-networking gobject-introspection gtk3 setuptools ];
nativeBuildInputs = [ gettext wrapGAppsHook ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [ glib-networking gobject-introspection gtk3 setuptools ];
nativeBuildInputs = [ gettext wrapGAppsHook ];
nativeBuildInputs = [ gettext wrapGAppsHook ];
buildInputs = [ glib-networking gobject-introspection gtk3 setuptools ];

maintainers = with maintainers; [ joshuafern ];
platforms = platforms.linux;
};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing final newline.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 85658 run on x86_64-linux 1

1 package built:
  • minigalaxy

@stale
Copy link

stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2021
@JoshuaFern
Copy link
Member Author

Closing this stale PR.

@JoshuaFern JoshuaFern closed this Sep 4, 2021
@JoshuaFern JoshuaFern deleted the minigalaxy branch October 8, 2021 23:29
@rapenne-s rapenne-s mentioned this pull request Dec 17, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants