New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocamlPackages.alcotest: 0.8.5 → 1.0.1 #85194
Conversation
@GrahamcOfBorg build stog jackline |
|
||
# Fix test-suite for alcotest ≥ 1.0 | ||
patches = [(fetchpatch { | ||
url = "https://github.com/mirage/ocaml-base64/commit/8d334d02aa52875158fae3e2fb8fe0a5596598d0.patch"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not update base64
to 3.4.0 which contains this commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe next PR…
|
||
doCheck = true; | ||
checkInputs = lib.optional doCheck alcotest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but doesn't mkDerivation
already remove checkInputs
for you if doCheck
is disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Thanks for the hint.
@@ -12,6 +12,9 @@ buildDunePackage rec { | |||
sha256 = "09g4zngqiw97cljv8ds4m063wcxz3y7c7vzaprsbpjzi0ja5jdcy"; | |||
}; | |||
|
|||
# Fix tests with alcotest ≥ 1 | |||
patches = [ ./test_conv_ml.patch ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use fetchpatch
here: mirage/digestif@b65d996
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
76f470c
to
b721624
Compare
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)