Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.pylatexenc: 2.1 -> 2.2 #85676

Merged
merged 1 commit into from Apr 22, 2020
Merged

python2Packages.pylatexenc: 2.1 -> 2.2 #85676

merged 1 commit into from Apr 22, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Apr 21, 2020 •
edited

Motivation for this change

Version bump hit last night. https://github.com/phfaist/pylatexenc/releases/tag/v2.2
Cleans up some meta/test too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.pylatexenc python37Packages.pylatexenc python38Packages.pylatexenc
downstream packages like python3Packages.qiskit-terra currently fail due to #83888 merge causing scipy failures (see #84943 (comment)), so nixpkgs-review pr 85676 doesn't run cleanly.

@drewrisinger drewrisinger marked this pull request as ready for review April 21, 2020 13:08
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.pylatexenc python37Packages.pylatexenc python38Packages.pylatexenc

@jonringer
Copy link
Contributor

unfortunately, this causes rebuilds of scipy and a few other heavy weight packages. But I am building it. Also, I should have my 3990X server up soon, which should be able to to build these very quickly.

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Apr 22, 2020 via email

jonringer
jonringer approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 85676 1

14 packages built: - python27Packages.pylatexenc - python37Packages.pylatexenc - python37Packages.qasm2image - python37Packages.qiskit - python37Packages.qiskit-aer - python37Packages.qiskit-aqua - python37Packages.qiskit-ibmq-provider - python37Packages.qiskit-ignis - python37Packages.qiskit-terra - python38Packages.pylatexenc - python38Packages.qiskit-aer - python38Packages.qiskit-aqua - python38Packages.qiskit-ignis - python38Packages.qiskit-terra

@jonringer jonringer merged commit 512a85d into NixOS:master Apr 22, 2020
@drewrisinger drewrisinger deleted the dr-pr-pylatexenc branch April 22, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer