Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.Euterpea: fix build, unbreak #85611

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Build was failing due to unnecessary version constraints. The project is taking its time fixing it and it's very easy to patch (See Euterpea/Euterpea2#40).

Things done

Build all haskellPackages that depend on Euterpea:

  • HSoM: builds fine
  • Jazzkell: builds fine
  • hs-pattrans: broken due to unrelated issue
  • myTestlll: broken due to unrelated issue
  • mezzo: broken due to unrelated issue
  • Kulitta: builds fine
  • AlgoRhythm: broken due to unrelated issue
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 20, 2020
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sha256 in the patch file needs to be changed. Maybe instead of using the https://github.com/Euterpea/Euterpea2/pull/38.patch URL, you could just link directly to the commit in question. That way you know it won't change out from under you if the PR gets updated.

Here's what I got when trying to build this:

$ nix-build -A haskellPackages.Euterpea --arg config '{allowBroken=true;}'
these derivations will be built:
  /nix/store/snbkn69rr9zn828qqagwzfcgfqik79d7-38.patch.drv
  /nix/store/557mnw27p2hy1950ixmnl962n3jy3by0-Euterpea-2.0.7.drv
these paths will be fetched (6.51 MiB download, 47.70 MiB unpacked):
  /nix/store/0v90nid073gfp3fikw9q82a38a2p0kx6-Stream-0.4.7.2-doc
  /nix/store/17s7csrjl1xrs8vbvdzrpabv5g149b4d-lazysmallcheck-0.6-doc
  /nix/store/19gfzmrbb1nncqd7fpij14kli485icm8-Stream-0.4.7.2
...
building '/nix/store/snbkn69rr9zn828qqagwzfcgfqik79d7-38.patch.drv'...

trying https://github.com/Euterpea/Euterpea2/pull/38.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   143  100   143    0     0    361      0 --:--:-- --:--:-- --:--:--   361
100  1001    0  1001    0     0   1101      0 --:--:-- --:--:-- --:--:--  977k
hash mismatch in fixed-output derivation '/nix/store/zvf8fqhwrkd2lbwv9fysf4imdpqjhpfb-38.patch':
  wanted: sha256:06dh0rhqd9smc65r3lgxm6mbqrdg8sbqwyhc41mpr0csvn7kzgry
  got:    sha256:0g594ks4c1ls5xn0ywzj05dd897zwij1lnq6mijqfwh6bfwwh9da
cannot build derivation '/nix/store/557mnw27p2hy1950ixmnl962n3jy3by0-Euterpea-2.0.7.drv': 1 dependencies couldn't be built
error: build of '/nix/store/557mnw27p2hy1950ixmnl962n3jy3by0-Euterpea-2.0.7.drv' failed

Also, If I were to make one more comment, it would be that your version ranges in the patch you've linked to are probably too strict.

You'd probably be fine with HCodecs >= 0.5.1 && <= 0.6 and bytestring>=0.10.4.0 && <= 0.11.

Removing the upper bounds would probably be fine as well.

@cdepillabout
Copy link
Member

Oh yeah, one more thing.

If you've tested that HSoM, Jazzkel, etc build correctly now, please feel free to mark them unbroken in this same PR.

Build is failing due to too restrictive version constraints which were
the only thing needing fixing.
@sternenseemann
Copy link
Member Author

Made the version constraints more forgiving and fixed the hash (nix-prefetch-url is a bad idea with fetchpatch appearantly). I briefly checked, but Jazzkell, Kulitta and HSoM don't seem to be marked as broken.

@cdepillabout
Copy link
Member

Thanks for fixing this up.

I've confirmed that Euterpea builds!

@cdepillabout cdepillabout merged commit bf21b10 into NixOS:haskell-updates Apr 21, 2020
@sternenseemann sternenseemann deleted the haskell-updates branch April 21, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants