Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deployment.storeKeysOnMachine #1288

Merged
merged 1 commit into from Apr 20, 2020
Merged

Remove deployment.storeKeysOnMachine #1288

merged 1 commit into from Apr 20, 2020
+4 −72

Conversation

adisbladis
Copy link
Member

This is a dangerous options and persistent secrets can already be
achieved by setting a destDir to a persistent mutable location.

@adisbladis
Remove deployment.storeKeysOnMachine
705696c 
This is a dangerous options and persistent secrets can already be
achieved by setting a destDir to a persistent mutable location.
@grahamc
Copy link
Member

grahamc commented Apr 20, 2020 

13:32 <gchristensen> is anyone using nixops' storeKeysOnMachine?
13:32 <globin> gchristensen: we were thinking about starting to use it, why?
13:32 <gchristensen> I want to delete it
13:32 <globin> why?
13:32 <gchristensen> would your use case be supported by setting keys.name.destDir  to somewhere persistent instead?
13:33 <gchristensen> globin: it puts keys in the store
13:33 <globin> Ah then we wanted to use the destDir :)
13:33 <globin> ignore me
13:33 <gchristensen> we'll delete it then :P
13:33 <globin> +1

@grahamc grahamc added this to In progress in kanban Apr 20, 2020
@grahamc grahamc added this to the 2.0 milestone Apr 20, 2020
@grahamc grahamc merged commit acb8073 into NixOS:master Apr 20, 2020
kanban automation moved this from In progress to Done Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
kanban
  
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @grahamc