Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moonplus: init at 0.3.8 #85610

Closed
wants to merge 1 commit into from
Closed

moonplus: init at 0.3.8 #85610

wants to merge 1 commit into from

Conversation

Xe
Copy link
Contributor

@Xe Xe commented Apr 20, 2020 •
edited

Motivation for this change

Adding MoonPlus for faster MoonScript -> Lua translation

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    This package is 1.4 megabytes uncompressed.
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

delroth
delroth reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your fixup commit to avoid noise in the git log.

pkgs/development/compilers/moonplus/default.nix Outdated Show resolved Hide resolved
@Xe
moonplus: init at 0.3.8
6ef9be4 
Update default.nix

moonplus: use pname
@Xe Xe closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xe @delroth