Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.GitAutofixup: init at 0.002007 #85654

Merged
merged 1 commit into from Apr 26, 2020
Merged

perlPackages.GitAutofixup: init at 0.002007 #85654

merged 1 commit into from Apr 26, 2020

Conversation

DamienCassou
Copy link
Contributor

Motivation for this change

Add git autofixup

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DamienCassou DamienCassou force-pushed the damien/git-autofixup branch 3 times, most recently from 14b6a39 to bddaab9 Compare April 26, 2020 16:38
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build perlPackages.GitAutofixup

@worldofpeace
Copy link
Contributor

Commit message needs the full perlPackages.GitAutofixup attribute

cole-h
cole-h approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. git autofixup --help displays a helpful man page.

EDIT: After the commit message is fixed, should be good to go :)

[4 built, 1 copied (51.9 MiB), 8.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/85654
2 packages built:
perl528Packages.GitAutofixup perl530Packages.GitAutofixup

@worldofpeace worldofpeace changed the title GitAutofixup: init at 0.002007 perlPackages.GitAutofixup: init at 0.002007 Apr 26, 2020
@worldofpeace worldofpeace merged commit c351f28 into NixOS:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DamienCassou @worldofpeace @cole-h