Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.webify: fix build #85662

Merged

Conversation

erictapen
Copy link
Member

Webify needs a bump in the cabal file. As the last upstream commit is two years ago, I think it makes sense to not wait for upstream to merge the PR and release a new version.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

webify needs a bump in the cabal file. As the last upstream commit is
two years ago, I think it makes sense to not wait for upstream to merge
the PR [0] and release a new version.

[0] ananthakumaran/webify#27
@erictapen erictapen force-pushed the webify-bump-optparse-applicative branch from 2098842 to b60bbcf Compare April 21, 2020 09:16
@cdepillabout
Copy link
Member

This looks good! Thanks for adding a comment here.

@cdepillabout cdepillabout merged commit d45a2ad into NixOS:haskell-updates Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants