New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick nitpicking on what I can spot. Can't really validate the flow itself, just the syntax and how GitHub Actions are used :)
Oooh... does this mean we'll start seeing "regular" PyPI releases? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments; LGTM, but I cannot judge the context. But I am sure you either tested it, or this merge will test it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM .. for what-ever that is worth :)
Merging, as TB has approved. |
Not finished yet
See if build artefacts can be attached to the releaseNot worth the botherPYPI_PASSWORD
secrets to repoLatest release build example: https://github.com/LordAro/nml/actions/runs/83157723