Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r8125: 9.003.02 -> 9.003.05 #85669

Merged
merged 1 commit into from Jul 7, 2020
Merged

r8125: 9.003.02 -> 9.003.05 #85669

merged 1 commit into from Jul 7, 2020

Conversation

notpeelz
Copy link

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested the kernel module Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor

Maybe this should target staging because it forces a rebuild of the Linux kernel?? Not honestly sure about how the process for getting driver updates accepted works. Working on building locally in meantime, but running into a few build problems, looks like it's due to my machine though (e.g. running out of space).

@notpeelz
Copy link
Author

notpeelz commented Apr 28, 2020

Not sure, perhaps @jonringer would know.

Also note that 9.003.04 is broken on the latest kernel (5.6) as Realtek hasn't released a new version yet.

@drewrisinger
Copy link
Contributor

Here's the result of my nixpkgs-review pr 85669. Take some of this with a grain of salt b/c of the "out of space" issue mentioned above.

https://github.com/NixOS/nixpkgs/pull/85669
2 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_latest.r8125

6 package failed to build:
linuxPackages_5_6.r8125 linuxPackages_latest-libre.r8125 linuxPackages_latest_hardened.r8125 linuxPackages_latest_xen_dom0.r8125 linuxPackages_latest_xen_dom0_hardened.r8125 linuxPackages_xen_dom0_hardened.r8125

10 package built:
linuxPackages-libre.r8125 linuxPackages.r8125 linuxPackages_4_14.r8125 linuxPackages_4_19.r8125 linuxPackages_4_4.r8125 linuxPackages_4_9.r8125 linuxPackages_5_5.r8125 linuxPackages_hardened.r8125 linuxPackages_testing_bcachefs.r8125 linuxPackages_xen_dom0.r8125

@notpeelz
Copy link
Author

All of the linuxPackages_latest and linuxPackages_5_6 are expected to fail because r8125 hasn't been updated for that kernel yet. Not sure about linuxPackages_xen_dom0_hardened.

@notpeelz notpeelz changed the title r8125: 9.003.02 -> 9.003.04 r8125: 9.003.02 -> 9.003.05 Jul 7, 2020
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds cleanly via nix-review (except for marked broken, see below)
  • NOT TESTED. Not sure how to test.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/181

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @louistakepillz thanks for the update, @drewrisinger thanks for the review 👍

Result of nixpkgs-review pr 85669 1

2 packages marked as broken and skipped:
- linuxPackages_hardkernel_4_14.r8125
- linuxPackages_hardkernel_latest.r8125
16 packages built:
- linuxPackages-libre.r8125
- linuxPackages.r8125 (linuxPackages_5_4.r8125)
- linuxPackages_4_14.r8125
- linuxPackages_4_19.r8125
- linuxPackages_4_4.r8125
- linuxPackages_4_9.r8125
- linuxPackages_5_6.r8125
- linuxPackages_5_7.r8125 (linuxPackages_latest.r8125)
- linuxPackages_hardened.r8125
- linuxPackages_latest-libre.r8125
- linuxPackages_latest_hardened.r8125
- linuxPackages_latest_xen_dom0.r8125
- linuxPackages_latest_xen_dom0_hardened.r8125
- linuxPackages_testing_bcachefs.r8125
- linuxPackages_xen_dom0.r8125
- linuxPackages_xen_dom0_hardened.r8125

@danieldk danieldk merged commit 64949ae into NixOS:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants