New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r8125: 9.003.02 -> 9.003.05 #85669
r8125: 9.003.02 -> 9.003.05 #85669
Conversation
Maybe this should target staging because it forces a rebuild of the Linux kernel?? Not honestly sure about how the process for getting driver updates accepted works. Working on building locally in meantime, but running into a few build problems, looks like it's due to my machine though (e.g. running out of space). |
Not sure, perhaps @jonringer would know. Also note that 9.003.04 is broken on the latest kernel (5.6) as Realtek hasn't released a new version yet. |
Here's the result of my
|
All of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Diff LGTM
- Commits LGTM
- Builds cleanly via nix-review (except for marked broken, see below)
- NOT TESTED. Not sure how to test.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @louistakepillz thanks for the update, @drewrisinger thanks for the review 👍
Result of nixpkgs-review pr 85669
1
2 packages marked as broken and skipped:
- linuxPackages_hardkernel_4_14.r8125
- linuxPackages_hardkernel_latest.r8125
16 packages built:
- linuxPackages-libre.r8125
- linuxPackages.r8125 (linuxPackages_5_4.r8125)
- linuxPackages_4_14.r8125
- linuxPackages_4_19.r8125
- linuxPackages_4_4.r8125
- linuxPackages_4_9.r8125
- linuxPackages_5_6.r8125
- linuxPackages_5_7.r8125 (linuxPackages_latest.r8125)
- linuxPackages_hardened.r8125
- linuxPackages_latest-libre.r8125
- linuxPackages_latest_hardened.r8125
- linuxPackages_latest_xen_dom0.r8125
- linuxPackages_latest_xen_dom0_hardened.r8125
- linuxPackages_testing_bcachefs.r8125
- linuxPackages_xen_dom0.r8125
- linuxPackages_xen_dom0_hardened.r8125
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in./result/bin/
)nix path-info -S
before and after)