Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 5dc6f02d7799
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 45a04ed6d49a
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 21, 2020

  1. gbsplay: fix configure flags

    This caused none of these flags to have any effect.  That's because
    the configure command looked like this:
    
        ./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \
            --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n
    
    with one giant flag '--without-test --without-contrib...', containing
    internal spaces.
    
    This can be seen in `nix log nixpkgs.gbsplay`, in this line:
    
        configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n
    
    and then in the fact that features like "devdsp" and "midi" are listed
    as enabled in later output, and source files like plugout_midi.c are
    included in the build.
    
    I don't have a real opinion on whether it's better to have these flags
    or not, but it's clear the author's intention was to pass them.  So,
    fix the attr name so they get passed.
    gnprice authored and FRidh committed Apr 21, 2020
    Copy the full SHA
    45a04ed View commit details
    Browse the repository at this point in the history