New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some niche features #1312
Conversation
Maybe we should make a repo for useful modules which also don't belong in nixpkgs, and refer to it in a changelog entry? |
really nice that they're not actually using any code in nixops itself, and the modules can just be dropped in |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
LGTM but let's make that repo and move these expressions over. I asked in #nix-community on IRC about a good repo name for it. Once we do and move the exprs, let's make a link to it from the readme. |
I've split the history of auto-luks and auto-raid0 in to https://github.com/nix-community/nixos-modules-contrib. We probably should have been doing this from the start, but I'll add a changelog entry for this. |
f2106a4
to
ca3e4b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd merge but I want you to take a look, @adisbladis first.
@grahamc I think we really need a story for how to get https://github.com/nix-community/nixos-modules-contrib into peoples NixOps deployments. |
That sounds good to me. We might want to get the nixos-infect file a better home, too, while we're at it? |
Actually thinking about this a bit more I realised it doesn't make much sense to make the external repo a NixOps plugin as it's not directly tied to NixOps, it's just external NixOps modules. So my recommendation to users in this instance would be to use Niv, or at a later date Nix flakes. |
|
I agree about not doing the plugin, and leaving that for other solutions like niv, flakes, or another mechanism. That said, if someone wanted to make the plugin, that would be great. |
Just did a rebase and trivial fix-up of including the 2.0 notes in the toc, and fixing header's underbars. |
See #1242
Please note that this is not about just removing these features. They will be reintroduced as plugins.