Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple build nixpkgs from released nixpkgs #401

Closed
wants to merge 1 commit into from

Conversation

samueldr
Copy link
Member

The eager update to use 20.03 to build the flake accidentally made the
site use the 20.03 manual.

This change allows us to move forward the infrastructure of the site
in preparation for a release, without actually using that version's
manual.

Additionally, it's not much of an issue, the list of AMIs could have
been using the wrong list (of an unreleased branch), though as it
requires manual involvement of the team it wouldn't have been an issue.

Fixes #400.

The eager update to use 20.03 to *build* the flake accidentally made the
site use the 20.03 manual.

This change allows us to move forward the infrastructure of the site
in preparation for a release, without actually using that version's
manual.

Additionally, it's not much of an issue, the list of AMIs could have
been using the wrong list (of an unreleased branch), though as it
requires manual involvement of the team it wouldn't have been an issue.

Fixes #400.
@github-actions
Copy link
Contributor

@samueldr
Copy link
Member Author

[15:52:48] <cole-h> samueldr: Though I'm a little curious why you point to `edolstra/nixpkgs` for released instead of `NixOS/nixpkgs`
[15:53:30] <samueldr> cole-h: good question, and the answer is surprisingly simple: that's how the flake is registered in the registry, and that's the flake that was used prior to the breaking change

@garbas garbas mentioned this pull request Apr 20, 2020
@worldofpeace
Copy link
Contributor

This is included in #392

@samueldr samueldr deleted the fix/released-manual branch April 21, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple the nixos/nixpkgs manuals from the nixpkgs flake input
2 participants