New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: first version of the bananas_server rewritten in Python #1
Conversation
79a4df5
to
28e8f6f
Compare
d2394c1
to
7050fc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts that occurred to me as i scrolled through the "diff", nothing too in depth
c11edba
to
b33bdc2
Compare
eb74c5c
to
24dd659
Compare
c365821
to
bcb2419
Compare
a77d384
to
4d68532
Compare
It serves the TCP and HTTP connections from the OpenTTD client. This repository in combination with bananas-api allows you to run your own BaNaNaS from scratch.
4d68532
to
c21984e
Compare
(letter >= "a" and letter <= "z") | ||
or (letter >= "A" and letter <= "Z") | ||
or (letter >= "0" and letter <= "9") | ||
or letter == "." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not allow "." in first position?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not disagreeing, but there are more things I would like to fix. For now I did what musa did:
https://github.com/OpenTTD/musa/blob/68bf7d1f1983f028ec2b2a775fe421618d6a4c0c/misc.py#L91
(only written in better Python). I guess we can clean up some more .. like no starting with _ or ending with it :D
It serves the TCP and HTTP connections from the OpenTTD client,
and requires the BaNaNaS repository to be checked out.
This repository in combination with bananas-api allows you to
run your own BaNaNaS from scratch.