Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hamster: init at 3.0.2 #90051

Merged
merged 2 commits into from Jun 16, 2020
Merged

Conversation

fabianhauser
Copy link
Member

Motivation for this change

Add the hamster time tracking application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g
Copy link
Member

das-g commented Jun 10, 2020

$> ls /nix/store/5v1zvr531ndsd960g5iplb8g5ym7hxri-hamster-time-tracker-3.0.2/bin -A
hamster  .hamster-wrapped  ..hamster-wrapped-wrapped

..hamster-wrapped-wrapped is an interesting name, but I guess it's up to the wrappers and not the individual package to do this saner when wrappers are combined with each other. 🙃

@das-g
Copy link
Member

das-g commented Jun 10, 2020

$> ls /nix/store/5v1zvr531ndsd960g5iplb8g5ym7hxri-hamster-time-tracker-3.0.2/bin -A
hamster  .hamster-wrapped  ..hamster-wrapped-wrapped

..hamster-wrapped-wrapped is an interesting name, but I guess it's up to the wrappers and not the individual package to do this saner when wrappers are combined with each other. upside_down_face

Alright, I was wrong; It seems that at least for now, it actually is the package's responsibility to combine the wrappers properly. (See also #90051 (comment).)

For Python applications, the manual advises to do that with

{
  #...

  dontWrapGApps = true;

  # Arguments to be passed to `makeWrapper`, only used by buildPython*
  preFixup = ''
    makeWrapperArgs+=("''${gappsWrapperArgs[@]}")
  '';

@fabianhauser fabianhauser force-pushed the hamster-time-tracker branch 2 times, most recently from 56c30bb to abe3f94 Compare June 10, 2020 16:10
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM,
commits LGTM

Result of nixpkgs-review pr 90051 1

1 package blacklisted:
- tests.nixos-functions.nixos-test
1 package built:
- hamster

:shipit: Ship it!

Edit: Some issues are yet unresolved.

pkgs/applications/misc/hamster/default.nix Outdated Show resolved Hide resolved
@fabianhauser fabianhauser changed the title hamster-time-tracker: init at 3.0.2 WIP: hamster-time-tracker: init at 3.0.2 Jun 10, 2020
@das-g das-g self-requested a review June 10, 2020 16:31
@fabianhauser fabianhauser force-pushed the hamster-time-tracker branch 3 times, most recently from 2804cd0 to a438e3e Compare June 10, 2020 19:17
@fabianhauser fabianhauser changed the title WIP: hamster-time-tracker: init at 3.0.2 hamster: init at 3.0.2 Jun 10, 2020
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now for real (as of 9c95e81):

👍 change LGTM
👍 both commits LGTM

Result of nixpkgs-review pr 90051 1

1 package built:
- hamster

Tested programs.hamster.enable = true; in VM:
✔️ GNOME icon for hamster present
✔️ application can be launched
✔️ entries can be authored
✔️ entries are stored across application sessions

:shipit: Ship it!

@jtojnar jtojnar merged commit 75e756b into NixOS:master Jun 16, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jun 16, 2020

Thanks.

@fabianhauser fabianhauser deleted the hamster-time-tracker branch August 28, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants