-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hamster: init at 3.0.2 #90051
hamster: init at 3.0.2 #90051
Conversation
89d6d66
to
41829d5
Compare
|
Alright, I was wrong; It seems that at least for now, it actually is the package's responsibility to combine the wrappers properly. (See also #90051 (comment).) For Python applications, the manual advises to do that with {
#...
dontWrapGApps = true;
# Arguments to be passed to `makeWrapper`, only used by buildPython*
preFixup = ''
makeWrapperArgs+=("''${gappsWrapperArgs[@]}")
''; |
56c30bb
to
abe3f94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change LGTM,
commits LGTM
Result of
nixpkgs-review pr 90051
11 package blacklisted:
- tests.nixos-functions.nixos-test1 package built:
- hamster
Ship it!
Edit: Some issues are yet unresolved.
2804cd0
to
a438e3e
Compare
a438e3e
to
9c95e81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now for real (as of 9c95e81):
👍 change LGTM
👍 both commits LGTM
Result of
nixpkgs-review pr 90051
11 package built:
- hamster
Tested programs.hamster.enable = true;
in VM:
✔️ GNOME icon for hamster present
✔️ application can be launched
✔️ entries can be authored
✔️ entries are stored across application sessions
Ship it!
Thanks. |
Motivation for this change
Add the hamster time tracking application.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)