New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
piccata 1.0.1 -> 2.0.0 #90105
piccata 1.0.1 -> 2.0.0 #90105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/90105
2 packages failed to build:
nrfutil python27Packages.piccata
2 packages built:
python37Packages.piccata python38Packages.piccata
Thanks for the review :) Yes, as mentioned above:
I did get nrfutil building, but there are quite a few patches required to get there.
... and then once this PR and the above are merged, I would submit the remaining patches: ... all so I can finally fix nrfutil: Again, pls let me know if you'd like to see all patches together or if I should follow the current plan. |
@siriobalmelli please apply my suggestion under the approval, so that the python2 package fails at evaluation time, instead of build time. Otherwise LGTM |
Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the commits. This can be done with:
|
699163c
to
d6990d0
Compare
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
d6990d0
to
698c5d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 90105 1
2 packages built:
- python37Packages.piccata
- python38Packages.piccata
Motivation for this change
Needed piccata working with Python3, upgraded to latest version.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)NOTE: