Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyspinel: fix build #90108

Merged
merged 1 commit into from Jul 9, 2020
Merged

python3Packages.pyspinel: fix build #90108

merged 1 commit into from Jul 9, 2020

Conversation

siriobalmelli
Copy link
Contributor

Motivation for this change

Update to reference an upstream fix to build on python >=3.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from gebner June 11, 2020 00:54
@siriobalmelli siriobalmelli mentioned this pull request Jun 11, 2020
Merged
10 tasks
@siriobalmelli siriobalmelli force-pushed the fix/pyspinel branch 3 times, most recently from b97a5cb to 7d38b91 Compare June 20, 2020 14:16
@siriobalmelli siriobalmelli changed the title Fix/pyspinel pyspinel: fix python3 build Jun 20, 2020
@jonringer
Copy link
Contributor

sorry for all the round about trips.
To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

python3Packages.pyspinel: fix build

@siriobalmelli siriobalmelli changed the title pyspinel: fix python3 build python3Packages.pyspinel: fix build Jun 27, 2020
@siriobalmelli siriobalmelli force-pushed the fix/pyspinel branch 2 times, most recently from 565abf8 to 50f9e5c Compare July 8, 2020 13:10
jonringer
jonringer reviewed Jul 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, the package is missing a license, please include

pkgs/development/python-modules/pyspinel/default.nix Show resolved Hide resolved
@siriobalmelli @jonringer
python3Packages.pyspinel: fix build
ea4d917 
Adopt upstream patch accepted here:
openthread/pyspinel#98

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
jonringer
jonringer approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 90108 1

2 packages built:
- python37Packages.pyspinel
- python38Packages.pyspinel

@jonringer jonringer merged commit 669de6d into NixOS:master Jul 9, 2020
@siriobalmelli siriobalmelli deleted the fix/pyspinel branch July 9, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siriobalmelli @jonringer