Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.hasql-notifications: unbreak #90062

Merged
merged 1 commit into from Jun 12, 2020

Conversation

steve-chavez
Copy link
Member

Motivation for this change

With hasql-pool unbroken (#85206), the hasql-notifications package that depends on it is also no longer broken.

Like with hasql-pool, the hasql-notifications test suite depends on running a PostgreSQL server. So dontCheck is set in place.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

cdepillabout commented Jun 11, 2020

@steve-chavez Could you rebase this on the haskell-updates branch (instead of master), and change the base branch here on github as well?

Oh, and haskell-updates recently switched from LTS-15 to LTS-16, so you might want to do a quick check that these packages you're interested in still compile.

@peti peti merged commit 2218618 into NixOS:master Jun 12, 2020
@peti
Copy link
Member

peti commented Jun 12, 2020

I'm working on haskell-updates right now, so I figured I'll just merge this and deal with the fallout (should there be any). :-)

@steve-chavez
Copy link
Member Author

@cdepillabout Sorry for the late reply, really appreciate your prompt review.

@peti Thank you! I'll help if there are any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants