Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slurm: 19.05.5.1 -> 19.05.7.1 (+bugfixes) #90041

Merged
merged 3 commits into from Jun 10, 2020
Merged

slurm: 19.05.5.1 -> 19.05.7.1 (+bugfixes) #90041

merged 3 commits into from Jun 10, 2020

Conversation

markuskowa
Copy link
Member

Motivation for this change

Bugfix relase and a bugfix that prevents slurmd from crashing, when submitting jobs with --export or --get-user-env.
Needs back port to 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
slurm: 19.05.5.1 -> 19.05.7.1
af4491f
@markuskowa
slurm: bugifx, add su/echo paths
5d8f61f 
slurmd requires su and echo to work with "--get-user-env". If slurmd
does not find /bin/su or /bin/echo, it crashes.
@ofborg ofborg bot requested a review from jagajaga June 10, 2020 10:59
@markuskowa
Copy link
Member Author

@GrahamcOfBorg test slurm

@markuskowa markuskowa added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 10, 2020
@markuskowa markuskowa changed the title slurm: 19.05.5.1 -> 19.05.6.1 (+bugfixes) slurm: 19.05.5.1 -> 19.05.7.1 (+bugfixes) Jun 10, 2020
@markuskowa markuskowa merged commit 69c8911 into NixOS:master Jun 10, 2020
@markuskowa markuskowa deleted the upd-slurm-19.05 branch June 10, 2020 14:23
@markuskowa
Copy link
Member Author

Back ported to 20.03 in 118e07c and 8946799

markuskowa added a commit to markuskowa/nixpkgs that referenced this pull request Jun 26, 2020
@markuskowa
slurm: add patch to allow full path lengths in --get-user-env
b8703b4 
Fix fallout from NixOS#90041
and 5d8f61f, which fixes
the crash of slurmd but "sbatch --get-user-env" did not work
properly.
@markuskowa markuskowa mentioned this pull request Jun 26, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@markuskowa