Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipewire: 0.3.5 -> 0.3.6 #90039

Merged
merged 1 commit into from Jun 10, 2020
Merged

pipewire: 0.3.5 -> 0.3.6 #90039

merged 1 commit into from Jun 10, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 10, 2020

should fix bad v0 clients, such as google-chrome-stable etc:
https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/014e48c1f1c47404653f597e500314cbf021056d

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/gnome

@jtojnar
Copy link
Contributor

jtojnar commented Jun 10, 2020

Changes look okay: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/b04552b2522a2cdae9a246be6ed77bb5ae31cda3

Though it looks like it omits some things. Full changes:

b04552b2 0.3.6
e7cc0f69 libcamera: fix implicit dependency to libdrm
2c8292be docs: add some more info
8696ad44 docs: add some doc about SPA design
2b7e6e19 doc: annotate code block as c
9fd64283 docs: fix some typos
014e48c1 protocol: add workaround for bad v0 clients
62dd58a6 client: remove busy state from client in resource destroy
8f251fc7 docs: add some docs about SPA POD
a44bea0b tests: check cpu flags
f278ded9 example: use thread loop in example
180f2b0f client-node0: clean up resource
b91a7180 man: Add man pages for pw-jack, pw-pulse
d566c885 port: don't send reuse_buffer on node again
64fc8dda stream: check for NULL context
65798ca5 context: only set TERMINATED when -EPIPE
dac60d4e avoid some leaks and NULL pointer derefs
2fd64f15 connection: dup and close fds
aaaa5417 stream: don't destroy proxy twice
2462cac4 add some more debug
c13c028e bluez5: fix leaks
51ae60b0 portal: fix small leak
e493be38 scripts: Use special ${LIB} token for architecture-independence
96eb6e4d scripts: Don't add an empty entry to LD_LIBRARY_PATH
0efadbb2 client-node: free old mem after setting new mem
972a790c client-node: send error when node_set_io fails
6ee98531 jack: free old mem after we configure new mem
bf4ccc00 stream: destroy proxy
969377b0 client-node: simplify cleanup
ade5bcb5 local-v4l2: fix leaks
ee5d6b44 pulse: add more checks
cecbf319 example: use bound event to find node id
ef770f9c proxy: debug more errors
1b4b8a93 gst: check for NULL stream
1c86ed82 resource: fix errno printout in error message
2ae621c9 fix warning: passing argument 1 of ‘pa_proplist_iterate’ discards ‘const’ qualifier 	in pipewire-pulseaudio/src/proplist.c 	for pulseaudio version < 13.0
77860ef3 add version requirement for vulkan library dependency 	due to usage of VK_ERROR_OUT_OF_POOL_MEMORY, VK_ERROR_INVALID_EXTERNAL_HANDLE, 	VK_API_VERSION_1_1 and VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT 	introduced in version 1.1.69
549431e8 pulse: fix leaks
ed31ca30 media-session: improve cleanup of objects
47ae56df core: improve debug
4abd02be proxy: debug bound id
5d5bb23e proxy: add pw_proxy_ref() private method
5ad84913 pipewire: make pw_init() work after pw_deinit()
eb74b2bf buffers: fix warning
814b7426 jack: stop the thread loop before we destroy objects
253e3041 jack: destroy link proxy
38cfa2d7 jack: fix leaks
d69ff451 tools: fix leaks
49619f2b tools: fix leaks
fa04d2ee profiler: fix some leaks
30571d47 tools: fix some leaks
0ee7d811 core: only warn about leaked proxies
f1e7e86b buffers: add support for multiple data blocks
704d504a media-session: mark enabled modules with *
0b47b47b libcamera: disable by default
39974903 Rebasing
0d8e030c Removed datas field
d93870fd Removed redundant logs
af263187 Reverting redundant changes
9024cc44 Integrating libcamera
ee1b79c4 stream: setting a format always clears buffers
8292c556 client-node: first set param, then clear buffers
33cd2495 examples: add signal handler for clean exit
197ffe32 Makefile: set VALGRIND variable in valgrind
325280cb core: run extra step to warn/destroy leaked proxies
3060c57b examples: add cleanup
6d0fd7b5 remote-node: run _destroy in the _removed handler
a7225090 core: improve cleanup
4405fe4c remote-node: handle deleted client-node
6b313de2 examples: catch signal and clean up
702976ab context: avoid adding duplicate export types
8d0913c9 examples: add audio DSP source
baf3b0a2 pw-cat: zero out info
913ad434 filter: free ports as well
b4b7ba4c remote-node: suspend node before cleanup
e4e03fa7 media-session: always activate DSP nodes
94cbb545 stream: rename variable
203c89da pw-cat: cleanup registry proxy
3890f06c stream: let the node_destroy() destroy the proxy as well
3d22baab node: suspend before emiting destroy
17d7cdc8 spa-node-factory: cleanup node when binding the client resource fails
16c1a7fe spa-device-factory: destroy device when the creator resource is destroyed
0471ba7f Add pw_in_valgrind() to check running in valgrind
fda9e4d5 call _deinit(() in session manager exit
00d61d95 add pw_deinit() to cleanup resources
09913ca4 metadata: free when the global is destroyed
4dfd60f8 add some more debug
c4b87aa5 audioadapter: clear convert handle to avoid leaks
7d88c37e alsa-seq: clear the midi event queue on close to avoid leak
d2bd076a alsa: close output handler to avoid a leak
40609341 client-node: keep track of the client allocated fd
c04a9b54 client-node: refuse the wrong amount of client buffers
bb1cb530 add more debug of fd create and close
803c2860 mem: add flag to suppress notify
6ecbe007 session-manager: emit cached info with CHANGE_MASK_ALL on new resources
1eec6c35 session-manager: do not copy stream link params if they are NULL
6aeaebe2 mem: Clean up stray mappings
47966735 mem: Improve search for existing mapping
34dada9c media-session: install ctrl-C handler
1246116f bluez: free object path
fbaa4dde stream: allow NULL param and 0 buffers in disconnect
7f60ebff logger: handle file without '/' in it
bf483242 alsa-monitor: don't use NULL device reserve
871bb47e gst: handle pause/resume
6eba010d gst: do a sync before disconnect
48dea3d5 gst: handle stream create error
c546167a require meson 0.49
9fa68f6d neon: use regular registers only
60742d75 pw-cli: allocate nodes ids of the right size
08ffc507 midifile: fix CLAMP range of minor/mayor keys
6a689b3c client-node: don't ref destroyed resource
963b00b7 adapter: return an error when we can't find a format
d31c057b Remove some useless checks
8123e271 make sure we call va_end in all cases
c2028a16 Fix some leaks in error cases
8669fd03 initialize variables better
ce98162e Make sure we don't read too much
236ebeeb gst: fix bad unlock when pool acquire fails
78aaf6c0 gst: only pop and adjust choice when we pushed something
eb93f259 avoid some useless assignments
4f60dcad vulkan: check results of stat
f1dc3d97 vulkan: fix macro variables
ff4a3140 use fstat when we can
45c62dfd a2dp: check and log return value of fcntl
459acda6 client-node: use spa_system functions
a19bab4b avoid following NULL pointers
a898f21c improve debug
1b2f6491 format: handle NULL type info
d2c51ed2 ci: publish generated documentation from master on gitlab pages
df818f1e ci: update to use fdo ci-templates, fedora 32 and preserve less artifacts
31a3458c editorconfig: add exception for yml files that use 2-space indentation
98780cdb utils: fix spa_assert_se
9e6a0477 portal: add portal module again
0bb3de0d context: clean up permission check
2fe9c37f core: add some more debug
5aea6252 log: don't re-initialize the log level in pw_init()
f06a884f mididump: dump offset
09b6ef41 alsa: compare the scaled value to decide on xrun
fea16cca channelmix: support Midi volume control
498cb917 channelmix: fix enum_params
b4112968 log: handle logging of NULL object
56730197 alsa: report xrun
fefdc26f plugin: workaround for AVX intrinsic: "_mm256_setr_m128()" missing in GCC
cee1a26b build: skip unsupported compiler option  -Wimplicit-fallthrough for gcc version before 7.x
4000409c channelmix: allow smaller control buffers
055c8d6b channelmix: improve control handling
5e37131c channelmix: add control port to process control sequences
cab645d1 stream: we can get the index before we are ready
8d5571fa audiotestsrc: fix function signature
0a542497 fix error reporting
fdb3985f client-node: handle NULL port
a7d8e805 stream: do some extra checks

Maybe we should package libcamera? It is only disabled by default because distros do not package it: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/0b47b47b6c5e4fb7c1748625934272ed4583ecdc

@flokli
Copy link
Contributor Author

flokli commented Jun 10, 2020

I would keep libcamera part of a follow-up PR.

@flokli flokli merged commit 9ad9ad8 into NixOS:master Jun 10, 2020
@flokli flokli deleted the pipewire-0.3.6 branch June 10, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants