Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyside2: don't fail import on missing shiboken2 #90103

Merged
merged 1 commit into from Jun 22, 2020
Merged

pythonPackages.pyside2: don't fail import on missing shiboken2 #90103

merged 1 commit into from Jun 22, 2020

Conversation

Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Jun 10, 2020 •
edited

Motivation for this change

Don't fail on
nix-shell -p "python3.withPackages (p: with p; [ pyside2 ])" --run 'python -c "import pyside2"'
with a ModuleNotFoundError: No module named 'shiboken2'.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
# before
/nix/store/w88qlmzijrqm68j8xx1xm1x8r9q6vlv7-pyside2-5.12.3       1419920272
# after
/nix/store/lyca0iilbgpj9izrdglm9zlvpc6hgznq-pyside2-5.12.3       1420060640

@Pamplemousse
pythonPackages.pyside2: resolve failing import
6df8995 
Currently,
  `nix-shell -p "python3.withPackages (p: with p; [ pyside2 ])" --run 'python -c "import pyside2"'`
fails with a:
  `ModuleNotFoundError: No module named 'shiboken2'`
@ofborg ofborg bot requested a review from gebner June 10, 2020 23:00
@gebner gebner merged commit d0ebf2d into NixOS:master Jun 22, 2020
@Pamplemousse Pamplemousse deleted the fix_pyside2 branch May 15, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pamplemousse @gebner