Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.python-engineio: build on macOS #90033

Merged
merged 2 commits into from Jun 15, 2020
Merged

python3Packages.python-engineio: build on macOS #90033

merged 2 commits into from Jun 15, 2020

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jun 10, 2020 •
edited

Motivation for this change

It builds just fine on macOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 10, 2020
@misuzu misuzu requested a review from Mic92 June 10, 2020 09:13
@misuzu
Copy link
Contributor Author

misuzu commented Jun 10, 2020 •
edited

Also tested building appdaemon on macOS, only one test is failing with OSError: AF_UNIX path too long, but that's because of very long path to tmp directory, for example:
path = '/private/var/folders/y1/9_wlrg890x1g723s7mgn73wr0000gn/T/nix-build-python3.7-aiohttp-3.6.2.drv-0/tmp1a3nap4t/tmp.sock'. Not sure why it's using different version of aiohttp.

Building python37Packages.aiohttp with --check is also failing on my machine, so this is probably local issue.

@Mic92
Copy link
Member

Mic92 commented Jun 13, 2020

Also tested building appdaemon on macOS, only one test is failing with OSError: AF_UNIX path too long, but that's because of very long path to tmp directory, for example:
path = '/private/var/folders/y1/9_wlrg890x1g723s7mgn73wr0000gn/T/nix-build-python3.7-aiohttp-3.6.2.drv-0/tmp1a3nap4t/tmp.sock'. Not sure why it's using different version of aiohttp.

Building python37Packages.aiohttp with --check is also failing on my machine, so this is probably local issue.

Can you either disable or fix new dependencies that are now failing because of enabling this?

@misuzu
Copy link
Contributor Author

misuzu commented Jun 13, 2020

@GrahamcOfBorg build appdaemon

@misuzu
Copy link
Contributor Author

misuzu commented Jun 13, 2020

Can you either disable or fix new dependencies that are now failing because of enabling this?

appdaemon is building on multi-user nix.

@misuzu
Copy link
Contributor Author

misuzu commented Jun 13, 2020

gdbgui build should be working too.

@GrahamcOfBorg build gdbgui

@Mic92
Copy link
Member

Mic92 commented Jun 14, 2020

Is your list complete?

@GrahamcOfBorg build gdbgui appdaemon

@misuzu
Copy link
Contributor Author

misuzu commented Jun 14, 2020

Is your list complete?

According to grep - it is :D

@Mic92 Mic92 merged commit bec05ce into NixOS:master Jun 15, 2020
@Mic92
Copy link
Member

Mic92 commented Jun 15, 2020

@misuzu nix-review is often the better tool to test all rebuilds.

@misuzu misuzu deleted the python-engineio-macos branch April 22, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@misuzu @Mic92