Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python packages for fake-useragent, scrapy-fake-useragent, scrapy-deltafetch, scrapy-splash #90071

Merged
merged 4 commits into from Jun 13, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Jun 10, 2020

Motivation for this change

Add several scrapy-related packages

Things done
  • Add fake-useragent
  • Add scrapy packages
    • Add scrapy-fake-useragent
    • Add scrapy-deltafetch
    • Add scrapy-splash

All of the above scrapy packages currently fail to compile on master with python38Packages, due to testfixtures failing to compile with such.

Everything seems to compile fine using python37Packages / python3Packages.

@evanjs
Copy link
Member Author

evanjs commented Jun 10, 2020

@ofborg build python37Packages.scrapy-fake-useragent python37Packages.scrapy-splash python37Packages.scrapy-deltafetch

@evanjs
Copy link
Member Author

evanjs commented Jun 13, 2020

All set. Squashed and cleaned up, etc.
Let me know if there's anything else.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/90071
3 packages failed to build:
python38Packages.scrapy-deltafetch python38Packages.scrapy-fake-useragent python38Packages.scrapy-splash

6 packages built:
python27Packages.fake-useragent python37Packages.fake-useragent python37Packages.scrapy-deltafetch python37Packages.scrapy-fake-useragent python37Packages.scrapy-splash python38Packages.fake-useragent

@jonringer jonringer merged commit 187a7f9 into NixOS:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants