Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal: 0.34 -> 0.35 #90038

Closed
wants to merge 1 commit into from
Closed

crystal: 0.34 -> 0.35 #90038

wants to merge 1 commit into from

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Jun 10, 2020

Motivation for this change

New Crystal Release: https://crystal-lang.org/2020/06/09/crystal-0.35.0-released.html

Before merging, we need to resolve #89863 first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@manveru
Copy link
Contributor Author

manveru commented Jun 10, 2020

For playing around @NixOS/crystal-lang

@manveru manveru marked this pull request as draft June 10, 2020 10:41
@manveru
Copy link
Contributor Author

manveru commented Jun 10, 2020

Also, trying to compile this with 0.34 fails because of changes to the doc generator... we probably have to write the buildPhase manually now to make it compile Crystal first and then use the compiled version to generate the docs.

@peterhoeg
Copy link
Member

Also, trying to compile this with 0.34 fails because of changes to the doc generator... we probably have to write the buildPhase manually now to make it compile Crystal first and then use the compiled version to generate the docs.

How about just building it with the binary 0.35?

FYI, 0.35.1 is out (and shards 0.11.1)

@lukateras lukateras removed their request for review June 24, 2020 06:38
@fabianhjr fabianhjr mentioned this pull request Nov 16, 2020
10 tasks
@fabianhjr
Copy link
Member

Also, trying to compile this with 0.34 fails because of changes to the doc generator... we probably have to write the buildPhase manually now to make it compile Crystal first and then use the compiled version to generate the docs.

I encountered this issue but decided to patch the makefile to mark the requirement to build the docs:

          # Add dependency of crystal to docs to avoid issue on flag changes between releases
          # https://github.com/crystal-lang/crystal/pull/8792#issuecomment-614004782
          substituteInPlace Makefile \
            --replace 'docs: ## Generate standard library documentation' 'docs: crystal ## Generate standard library documentation'

@fabianhjr
Copy link
Member

This should be closed as #103987 was merged.

@peterhoeg peterhoeg closed this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants