Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord-canary: 0.0.103 -> 0.0.104 #90012

Merged
merged 1 commit into from Jun 12, 2020
Merged

discord-canary: 0.0.103 -> 0.0.104 #90012

merged 1 commit into from Jun 12, 2020

Conversation

rileyinman
Copy link
Contributor

Motivation for this change

This update updates the necessary dependencies, and enables patchelf on
the binary in order to make it launch again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rileyinman
discord-canary: 0.0.103 -> 0.0.104
c48c187 
This update updates the necessary dependencies, and enables patchelf on
the binary in order to make it launch again.
@ofborg ofborg bot requested review from tadeokondrak, ldesgoui and MP2E June 10, 2020 05:36
@MP2E
Copy link

MP2E commented Jun 12, 2020

LGTM, thank you for the PR

@MP2E MP2E merged commit dbdc5af into NixOS:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

@ldesgoui ldesgoui Awaiting requested review from ldesgoui

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rileyinman @MP2E