Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.merlin: 3.3.4 → 3.3.6 #90085

Closed
wants to merge 1 commit into from
Closed

ocamlPackages.merlin: 3.3.4 → 3.3.6 #90085

wants to merge 1 commit into from

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 10, 2020 •
edited

Motivation for this change

Fixes & improvements: https://github.com/ocaml/merlin/releases/tag/v3.3.5 https://github.com/ocaml/merlin/releases/tag/v3.3.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl vbgl changed the title ocamlPackages.merlin: 3.3.4 → 3.3.5 ocamlPackages.merlin: 3.3.4 → 3.3.6 Jun 12, 2020
@vbgl
Copy link
Contributor Author

vbgl commented Jun 13, 2020 •
edited

@GrahamcOfBorg build ocamlPackages.merlin

@vbgl vbgl mentioned this pull request Jun 15, 2020
Merged
10 tasks
@vbgl vbgl closed this Jun 15, 2020
@vbgl vbgl deleted the ocaml-merlin-3.3.5 branch April 22, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl