Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/prometheus-apcupsd-exporter: new module #90077

Merged
merged 1 commit into from Jun 11, 2020
Merged

nixos/prometheus-apcupsd-exporter: new module #90077

merged 1 commit into from Jun 11, 2020

Conversation

mdlayher
Copy link
Member

Motivation for this change

apcupsd_exporter was packaged but did not have a NixOS module yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @Ma27 @WilliButz

@mdlayher mdlayher requested a review from WilliButz as a code owner June 10, 2020 18:15
@mdlayher mdlayher requested a review from Ma27 June 10, 2020 18:15
@mdlayher
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters

mmilata
mmilata approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward, LGTM + consider using the enum.

nixos/modules/services/monitoring/prometheus/exporters/apcupsd.nix Show resolved Hide resolved
nixos/modules/services/monitoring/prometheus/exporters/apcupsd.nix Outdated Show resolved Hide resolved
@mdlayher
nixos/prometheus-apcupsd-exporter: new module
e45146d 
Signed-off-by: Matt Layher <mdlayher@gmail.com>
@mdlayher
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters

@WilliButz
Copy link
Member

@mdlayher PR looks good to me.
GrahamcOfBorg doesn't actually run all exporter tests but you can request a specific test to be run as follows:
@GrahamcOfBorg test prometheus-exporters.apcupsd

@mdlayher
Copy link
Member Author

Good to know, thanks!

@WilliButz WilliButz merged commit 3190ba1 into NixOS:master Jun 11, 2020
@mdlayher mdlayher deleted the mdl-nixos-apcupsd branch June 11, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@WilliButz WilliButz WilliButz approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdlayher @WilliButz @mmilata