nixos/sympa: fix PATH_INFO splitting for sympa-6.2.56 #90067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our regex for splitting HTTP path into SCRIPT_NAME and PATH_INFO was incorrect when webLocation was set to "/". Since Sympa 6.2.56 this has caused the web interface to return "421 Misdirected Request". Since 6.2.56 Sympa can do the splitting on its own so we can simply remove it from nginx configuration. See also: - sympa-community/sympa#879 - sympa-community/sympa#910 - sympa-community/sympa-community.github.io#53
10 tasks
|
Apparently this was already picked to 20.03, so I think merging this is fine. That being said, cherry-picking for stable should happen when the commit has been merged into master. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Our regex for splitting HTTP path into SCRIPT_NAME and PATH_INFO was incorrect when webLocation was set to "/". Since Sympa 6.2.56 (updated in #89671) this has caused the web interface to return 421 Misdirected Request.
Since 6.2.56 Sympa can do the splitting on its own so we can simply remove it from nginx configuration.
See also:
fastcgi_split_path_infoand so on are no longer required sympa-community/sympa-community.github.io#53Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)