New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baobab: Fix missing icons on KDE #90030
Conversation
Does KDE not support SVG icons? |
From the few KDE apps I've packaged, they all use svgz icons and png for several sizes. |
But is there any issue with regular SVGs? I do not like introducing more complexity to the expression unless strictly required. |
Also, in case we really need the bitmap icons, they should be generated during build (using either Inkscape, or rsvg-convert), not included into the Nixpkgs repository. |
# Deletes traductions for Icon Entry in .desktop | ||
# And deletes the NotShowIn=KDE thing. | ||
postBuild = '' | ||
sed -i "/^Icon\[.*\].*$/d" data/org.gnome.baobab.desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is wrong with translations? Translators are explicitly told not to translate the icon names. It would only be used for RTL icon if applicable.
# And deletes the NotShowIn=KDE thing. | ||
postBuild = '' | ||
sed -i "/^Icon\[.*\].*$/d" data/org.gnome.baobab.desktop | ||
sed -i "/^NotShowIn=KDE;$/d" data/org.gnome.baobab.desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, apparently some people complained when they saw GNOME utilities in KDE 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I therefore close this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reasoning is ridiculous and we should remove this line upstream.
I do not see the other changes as necessary, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I really find this unreasonable. If they don't wan't to see it, they just have to uninstall it. They can even patch it and make their own baobab derivation with the NotShowIn entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. Could you send a merge request against https://gitlab.gnome.org/GNOME/baobab removing the line?
Motivation for this change
Missing baobab icons on KDE.
Things done
Fixed this, generated icons with inkscape from the .svg file in the source.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)