Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baobab: Fix missing icons on KDE #90030

Closed
wants to merge 1 commit into from

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

Missing baobab icons on KDE.

Things done

Fixed this, generated icons with inkscape from the .svg file in the source.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 10, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jun 10, 2020

Does KDE not support SVG icons?

@SCOTT-HAMILTON
Copy link
Contributor Author

From the few KDE apps I've packaged, they all use svgz icons and png for several sizes.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 10, 2020

But is there any issue with regular SVGs? I do not like introducing more complexity to the expression unless strictly required.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 10, 2020

Also, in case we really need the bitmap icons, they should be generated during build (using either Inkscape, or rsvg-convert), not included into the Nixpkgs repository.

# Deletes traductions for Icon Entry in .desktop
# And deletes the NotShowIn=KDE thing.
postBuild = ''
sed -i "/^Icon\[.*\].*$/d" data/org.gnome.baobab.desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong with translations? Translators are explicitly told not to translate the icon names. It would only be used for RTL icon if applicable.

# And deletes the NotShowIn=KDE thing.
postBuild = ''
sed -i "/^Icon\[.*\].*$/d" data/org.gnome.baobab.desktop
sed -i "/^NotShowIn=KDE;$/d" data/org.gnome.baobab.desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, apparently some people complained when they saw GNOME utilities in KDE 🤷‍♀️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I therefore close this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reasoning is ridiculous and we should remove this line upstream.

I do not see the other changes as necessary, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I really find this unreasonable. If they don't wan't to see it, they just have to uninstall it. They can even patch it and make their own baobab derivation with the NotShowIn entry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree. Could you send a merge request against https://gitlab.gnome.org/GNOME/baobab removing the line?

@SCOTT-HAMILTON
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants