Fix declarative jobset missing type value #762
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation will pass all values to
create_or_update
method. Themissing values will end up as
undef
(orNULL
) when assigned to%update
.Thus, for columns that are NOT NULL, when, for example, flakes are not used,
will result in a horrible:
This change just omits adding such values to
%update
, which results inPostgreSQL assigning the default values.
In addition,
type
column inJobsets
is defined as NOT NULL. However, the original upgradescript adding this column ommited the constraint. This change adds the upgrade script.
Fixes #761