mariadb: 10.4.12 -> 10.4.13 #87878
Merged
mariadb: 10.4.12 -> 10.4.13 #87878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanderse
reviewed
May 23, 2020
|
Added test mysql57 and mysql80 with unix auth. |
flokli
approved these changes
Jun 5, 2020
|
I'm a bit afraid of the test growing much larger and getting less readable - what do you think about refactoring this test to be a bit more dynamic, by passing in the specific mysql package under test as an argument, and instantiate it with all different flavours from We could still have some flavour-specifics as conditionals, but just avoid duplicating more and more code there. |
|
@flokli possible the variant of simply separatory into mysql57, mysql80 and mariadb? |
|
No, the goal is to have less code duplication. We don't solve this by moving this into separate files ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update mariadb to 10.4.13
Update mariadb-galera to 26.4.5
cc @aanderse @flokli
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)