Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopls: 0.4.0 -> 0.4.1 #87876

Merged
merged 1 commit into from May 15, 2020
Merged

gopls: 0.4.0 -> 0.4.1 #87876

merged 1 commit into from May 15, 2020

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented May 15, 2020

Motivation for this change

Long list of fixed issues in gopls. I don't want to toot the LSP horn too much but since this is a development tool, every editor wins.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented May 15, 2020

Result of nixpkgs-review pr 87876 1

1 package built:
- gopls

@Mic92 Mic92 merged commit 2645339 into NixOS:master May 15, 2020
@cryptix cryptix deleted the update-gopls branch May 15, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants