Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coq_8_11: 8.11.1 → 8.11.2 #87877

Merged
merged 1 commit into from May 20, 2020
Merged

coq_8_11: 8.11.1 → 8.11.2 #87877

merged 1 commit into from May 20, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented May 15, 2020

Motivation for this change

Bugfix release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

milibopp
milibopp approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@milibopp milibopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on NixOS x86_64
  • executables tested on NixOS x86_64
  • all depending packages build
Possible improvements
Comments

@vbgl vbgl merged commit 48f0d8b into NixOS:master May 20, 2020
@vbgl vbgl deleted the coq-8.11.2 branch May 20, 2020 17:21
@vbgl
Copy link
Contributor Author

vbgl commented Jun 9, 2020

Ported to 20.03 as ca6e453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

@milibopp milibopp milibopp approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@roconnor roconnor Awaiting requested review from roconnor

Assignees
No one assigned
Labels
6.topic: coq 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Zimmi48 @milibopp