Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.@nestjs/cli: init at 7.2.0 #87918

Merged
merged 1 commit into from Jun 19, 2020
Merged

nodePackages.@nestjs/cli: init at 7.2.0 #87918

merged 1 commit into from Jun 19, 2020

Conversation

leungbk
Copy link
Member

@leungbk leungbk commented May 16, 2020 •
edited

Motivation for this change

Add nestjs/cli, a NPM package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leungbk leungbk changed the title nodePackages_10_x.@nestjs/cli: init at 7.0.13 nodePackages.@nestjs/cli: init at 7.0.13 May 17, 2020
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after merging #89184

@leungbk
Copy link
Member Author

leungbk commented May 30, 2020

@prusnak OK, I resolved the merge conflict.

@leungbk leungbk changed the title nodePackages.@nestjs/cli: init at 7.0.13 nodePackages.@nestjs/cli: init at 7.2.0 May 30, 2020
@leungbk
Copy link
Member Author

leungbk commented Jun 3, 2020

@prusnak I've resolved the merge conflict again. If there are any obstacles to this getting merged, please let me know.

@leungbk
Copy link
Member Author

leungbk commented Jun 9, 2020

@prusnak

@leungbk leungbk requested a review from prusnak June 9, 2020 05:36
@leungbk
Copy link
Member Author

leungbk commented Jun 19, 2020

@prusnak

@prusnak
Copy link
Member

prusnak commented Jun 19, 2020

@leungbk I don't have merge permissions for this repo. Your PR needs to be merged by someone who has them.

@alyssais alyssais merged commit 36572ae into NixOS:master Jun 19, 2020
@leungbk leungbk deleted the nestjs branch September 5, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leungbk @prusnak @alyssais