Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php73: 7.3.16 -> 7.3.18 #87906

Closed
wants to merge 2 commits into from
Closed

php73: 7.3.16 -> 7.3.18 #87906

wants to merge 2 commits into from
+2 −2

Conversation

etu
Copy link
Contributor

@etu etu commented May 15, 2020

Motivation for this change

Changelog: https://www.php.net/ChangeLog-7.php#7.3.17

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This refs #85427

Sorry, something went wrong.

@etu
php73: 7.3.16 -> 7.3.17

Verified

This commit was signed with the committer’s verified signature.
sethmlarson Seth Michael Larson
GPG key ID: 7D5EC9FE0DE2C795
Verified
Learn about vigilant mode
94332cc 
Changelog: https://www.php.net/ChangeLog-7.php#7.3.17
@etu etu added the 9.needs: port to stable A PR needs a backport to the stable release. label May 15, 2020
@etu
Copy link
Contributor Author

etu commented May 15, 2020

cc @NixOS/php

@ofborg build php73

@ofborg ofborg bot requested review from talyz, Ma27, globin and aanderse May 15, 2020 20:26
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels May 15, 2020
@etu
php74: 7.3.17 -> 7.3.18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
95301bc 
Changelog: https://www.php.net/ChangeLog-7.php#7.3.18
@talyz talyz changed the title php73: 7.3.16 -> 7.3.17 php73: 7.3.16 -> 7.3.18 May 16, 2020
@talyz
Copy link
Contributor

talyz commented May 16, 2020

@GrahamcOfBorg build php73

@Ma27
Copy link
Member

Ma27 commented Jun 17, 2020

There's now 7.3.19 btw

@Ma27
Copy link
Member

Ma27 commented Jun 25, 2020

Superseded by #91495

@Ma27 Ma27 closed this Jun 25, 2020
@etu etu deleted the php73-update branch June 26, 2020 05:50
@talyz talyz removed the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz

@Ma27 Ma27

@globin globin

@aanderse aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @talyz @Ma27