Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php74: 7.4.4 -> 7.4.6 #87907

Merged
merged 2 commits into from May 16, 2020
Merged

php74: 7.4.4 -> 7.4.6 #87907

merged 2 commits into from May 16, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented May 15, 2020

Motivation for this change

Changelog: https://www.php.net/ChangeLog-7.php#7.4.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This refs #85427

@etu
Copy link
Contributor Author

etu commented May 15, 2020

cc @NixOS/php

@ofborg build php74

@ofborg ofborg bot requested review from Ma27, talyz, aanderse and globin May 15, 2020 20:36
@talyz talyz changed the title php74: 7.4.4 -> 7.4.5 php74: 7.4.4 -> 7.4.6 May 16, 2020
@etu
Copy link
Contributor Author

etu commented May 16, 2020

@ofborg test php

@etu
Copy link
Contributor Author

etu commented May 16, 2020

@ofborg build nixosTests.php

@etu etu mentioned this pull request May 16, 2020
Merged
10 tasks
@etu etu added the 8.has: port to stable A PR already has a backport to the stable release. label May 16, 2020
@etu etu merged commit 726cbe0 into NixOS:master May 16, 2020
@etu etu deleted the php74-update branch May 16, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @talyz