Document and fixup the "taxonomy" #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a premature optimization, as we don't have a family to implement and validate _just yet_, but we're still making the structure ready as both `asus-dumo` and `google-taimen` are subject to receive family members as soon as someone can test them.
It didn't make sense to stuff that into systems anyway, it's baggage from the first steps of making Mobile NixOS.
It didn't make sense to stuff that into systems anyway, it's baggage from the first steps of making Mobile NixOS. This is a *part* of android system types, so why stuff it into `system` at the root??
It didn't make sense to stuff that into systems anyway, it's baggage from the first steps of making Mobile NixOS. This is a *part* of depthcharge system type, so why stuff it into `system` at the root??
In addition, put the implementation of the build side-by-side with the system type definition. It made no sense to keep those where they were, as it was baggage from the earlier implementation of the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't clear when I started at first, and I was still dragging baggage from initial implementations.
Now, I have documented how it all works. Note that I have documented families, even though I have no family implemented yet. This is mainly to show how I thought about it, and I know it's 99% definitive we implement them that way. We already know that some Pixel devices share family traits (e.g. taimen/walleye → wahoo).
Though, since I don't have a family to "fix" with this cleaned-up taxonomy, I didn't end up implementing families' implementation details.
There is one breaking change, the QEMU system type name changed. I think that all builds should have been using
build.vmorbuild.defaultso it shouldn't actually break things.